Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When is active, the Spotlight shortcut stopped working #1

Closed
valencar opened this issue Jun 21, 2018 · 24 comments
Closed

When is active, the Spotlight shortcut stopped working #1

valencar opened this issue Jun 21, 2018 · 24 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@valencar
Copy link

The Cmd + Space shortcut, its not working.

@aahung
Copy link
Owner

aahung commented Jun 22, 2018

There is a new release with a debug window, can you try to invoke the shortcut and post the debug info here?

screen shot 2018-06-21 at 5 29 34 pm

screen shot 2018-06-21 at 5 30 02 pm

@azeemmohd
Copy link

@aahung I have the same issue, here's the log for cmd spacebar:
1529660969.939110 Key(49) Event(11) DISMISSED
1529660969.938952 Key(49) Event(10) DISMISSED
1529660969.936624 Key(49) Event(11)
1529660969.744665 Key(49) Event(10)

@aahung
Copy link
Owner

aahung commented Jun 22, 2018

@azeemmohd is it for a single "CMD+SPACE" hit or two?

@azeemmohd
Copy link

azeemmohd commented Jun 22, 2018

Single. I have temporarily mapped my spotlight to another shortcut.

@aahung
Copy link
Owner

aahung commented Jun 22, 2018

@azeemmohd That's odd, on my Mac when I hit "CMD+SPACE", there are only two lines, and you get 4 lines, which means "keydown + keyup + keydown + keyup"

1529661297.247138	 Key(49)	 Event(11)
1529661297.192024	 Key(49)	 Event(10)

@azeemmohd
Copy link

azeemmohd commented Jun 22, 2018 via email

@aahung
Copy link
Owner

aahung commented Jun 22, 2018

@azeemmohd can you try this version I just created? It will ignore "space" key for good.

Unshaky.app.zip

@azeemmohd
Copy link

azeemmohd commented Jun 22, 2018 via email

@aahung
Copy link
Owner

aahung commented Jun 22, 2018

@azeemmohd Cool I will update the release with this version.

aahung added a commit that referenced this issue Jun 22, 2018
@aahung
Copy link
Owner

aahung commented Jun 22, 2018

Since I cannot let it reappear on my Mac, I will leave this issue open for now.

@aahung
Copy link
Owner

aahung commented Jul 14, 2018

@valencar @azeemmohd , what are your OS versions? I wanna if it has something to do with it, like issue #5.

@aahung aahung added bug Something isn't working help wanted Extra attention is needed labels Aug 10, 2018
@aahung
Copy link
Owner

aahung commented Oct 18, 2018

I believe this issue is related to #8. I user from reddit reported his log below

First cmd + space (in that order)
1539852170.130042	 Key(55)	 Event(12)
1539852170.129072	 Key(49)	 Event(11) DISMISSED
1539852170.128513	 Key(49)	 Event(10) DISMISSED
1539852170.125920	 Key(49)	 Event(11)
1539852170.010203	 Key(49)	 Event(10)
1539852169.968837	 Key(55)	 Event(12)
Second
1539852217.898928	 Key(55)	 Event(12)
1539852217.882102	 Key(49)	 Event(11) DISMISSED
1539852217.881431	 Key(49)	 Event(10) DISMISSED
1539852217.878896	 Key(49)	 Event(11)
1539852217.752121	 Key(49)	 Event(10)
1539852217.677462	 Key(55)	 Event(12)
Third try
1539852269.224504	 Key(49)	 Event(11) DISMISSED
1539852269.223897	 Key(49)	 Event(10) DISMISSED
1539852269.222948	 Key(49)	 Event(11)
1539852269.214551	 Key(55)	 Event(12)
1539852269.070696	 Key(49)	 Event(10)
1539852268.983720	 Key(55)	 Event(12)

Notice key 55, which is command key, is registered. While on my Mac (and some other users) the command key is never registered in debug mode. Maybe this is the reason why I can never make this issue appear on my Mac. I will look into it later.

@aahung
Copy link
Owner

aahung commented Oct 18, 2018

I think I was wrong, 55 indeed showed up on my Mac :-(

@aahung
Copy link
Owner

aahung commented Oct 18, 2018

More report from that user: option+space does not induce two consecutive spaces. So command key is the reason.

And here's option+space:
1539853598.433661	 Key(49)	 Event(11)
1539853598.418123	 Key(58)	 Event(12)
1539853598.325666	 Key(49)	 Event(10)
1539853598.272385	 Key(58)	 Event(12)

@nerdvibe
Copy link

I worked around by setting the ms of delay for only the spacebar to 0. So far so good...

@ghost711
Copy link

ghost711 commented Nov 4, 2018

I just submitted pull request #18 for this issue. As you said @aahung , this is related to #8.
Key presses with CMD pressed results in double events in rapid succession, but it's possible to check event flags and ignore the duplicate if needed.

@aahung
Copy link
Owner

aahung commented Nov 4, 2018

@ghost711 you found it out. That's awesome! I never could reproduce this problem on my Mac.

@daothanhduy305
Copy link

daothanhduy305 commented Nov 17, 2018

@aahung Somehow the build I have built for myself including all the latest commits from the dev branch still have the issue with CMD + space.

MacOS 10.14.1 - mbp 2018 touch bar

Since I'm new to this project so if there is any information you need or so, just tell me and I would be pleased to provide you.

@aahung
Copy link
Owner

aahung commented Nov 19, 2018

@daothanhduy305 Currently dev branch is a failed experiment 😞. The PR #19 might resolve the CMD+SPACE issue, but create other issues. So a fully working workaround will come in the (foreseeable) future.

@ghost711
Copy link

Damn, that's too bad. It's still working perfect for my machine. Guess there must be more variables than I thought at first. Oh well. Good luck!

@aahung
Copy link
Owner

aahung commented Nov 19, 2018

As @ghost711 said, it might be ok now to try out #19 (just with a very small issue I think: possibly CMD+SPACE double press). I think I will soon come up with something adopting #19 method and in the meanwhile does not break the original functionality.

aahung added a commit that referenced this issue Nov 20, 2018
aahung added a commit that referenced this issue Nov 20, 2018
@aahung
Copy link
Owner

aahung commented Nov 20, 2018

Guys, please try this version of Unshaky (v0.3.0) and turn on the option below:

screen shot 2018-11-19 at 4 45 43 pm

@daothanhduy305
Copy link

daothanhduy305 commented Nov 20, 2018

Thanks, I'll try it later. Mine is currently at an AASP for a keyboard repair (Not only duplicating the spacebar but also it doesn't work for some pressing position).

@aahung I can confirm that now it works as expected with the version 0.3.0

@aahung
Copy link
Owner

aahung commented Nov 20, 2018

@daothanhduy305 that is great!

aahung added a commit that referenced this issue Nov 20, 2018
Add a workaround for #1, improved on #19
@aahung aahung closed this as completed Nov 21, 2018
aahung pushed a commit that referenced this issue Apr 12, 2019
aahung pushed a commit that referenced this issue Apr 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants