Fix CI #337
Merged
Fix CI #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue with package |
|
Mirage build looks like it needs robur-coop/ocaml-letsencrypt#34, which is awaiting release of ocaml/opam-repository#26454. Probably better to just ping and wait for that. |
aantron
changed the title
|
Amazing. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the pipeline to enable running tests again on Ubuntu and MacOS on OCaml verions 4.14.x and 5.0.x.
Windows builds require some more special attention. There were some errors during compilation of the ssl dependency. Logs can be found here: https://github.com/maxRN/dream/actions/runs/10508356669/job/29112078780
The Mirage tests are also failing, because of some dependency issues which I didn't have time to investigate further. Logs for those can be found here: https://github.com/maxRN/dream/actions/runs/10521553562/job/29152441822 (the other, non-mirage test failures can be ignored - I was just testing something in this run)