Use autotools instead of GYP to build libuv; works on Windows #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates the Python 3 dependency. Also, GYP was generating projects for Xcode on Mac, Visual Studio on Windows, etc. The new autotools build just directly uses whatever C compiler is being used by OCaml, which is guaranteed to already be installed and compatible.
The output of autotools is committed into the repo, so Luv doesn't pick up any new deps, either. It just depends on ordinary binaries like bash, make, etc. These are present in all environments commonly used with OCaml, including esy on Windows.
The libuv part of the build in this PR already works on Windows, with opam-repository-mingw. I still have two more things to do to finish Windows support:
I'll probably try GitHub Actions before doing these, for a Windows build in CI.
Closes #31.
Closes #43.
Also relevant to #40.
libuv itself is going to drop GYP soon. See libuv/libuv#2682.
cc @jordwalke @prometheansacrifice @ulrikstrid @lessp