Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make RenderObject a class instead of record #58

Closed
luithefirst opened this issue Nov 18, 2019 · 0 comments
Closed

make RenderObject a class instead of record #58

luithefirst opened this issue Nov 18, 2019 · 0 comments
Labels
cleanup
Milestone
5.4

Comments

@luithefirst
Copy link
Member

Structural equality is not intended and currently overwritten by custom implementation of Equals and GetHashCode -> using class would implicitly give that behavior

We should check if there are any forgotten unknown reasons of using a record. If not then cleanup in next major release.
@hyazinthh hyazinthh added this to the 5.4 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
5.4
Development

No branches or pull requests
2 participants
@luithefirst @hyazinthh