Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Quill sends multiple access tokens in a request #117

Open
jamietanna opened this issue Dec 26, 2019 · 2 comments
Open

[Bug] Quill sends multiple access tokens in a request #117

jamietanna opened this issue Dec 26, 2019 · 2 comments

Comments

@jamietanna
Copy link

While looking at aaronpk/micropub.rocks#84 it was noticed that requests to my Micropub endpoint were failing due to the inclusion of the Bearer token in both the Authorization header and the request body:

{
	"url" : "/micropub",
	"absoluteUrl" : "http://localhost:8085/micropub",
	"method" : "POST",
	"clientIp" : "173.230.197",
	"headers" : {
		"Authorization" : "Bearer ...",
		"Accept" : "application/json",
		"User-Agent" : "Go-http-client/1.1",
		"X-Forwarded-For" : "173.230.155.197",
		"Host" : "localhost:8085",
		"Accept-Encoding" : "gzip",
		"Content-Length" : "382",
		"Content-Type" : "application/x-www-form-urlencoded"
	},
	"cookies" : { },
	"browserProxyRequest" : false,
	"loggedDate" : 1577382107235,
	"body" : "h=entry&access_token=...&content=jjj",
	"scheme" : "http",
	"host" : "localhost",
	"port" : 8085,
	"loggedDateString" : "2019-12-26T17:41:47Z",
	"queryParams" : { }
}

This needs to be corrected to be fully OAuth2 compliant.

@jamietanna
Copy link
Author

Looks like this was first implemented in #4

@aaronpk
Copy link
Owner

aaronpk commented Dec 31, 2019

I've seen this cause more confusion than it has helped, so I'm in favor of changing this. I'll add a new setting which lets you choose whether you want the access token in the header or the post body.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants