Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement beam search #2

Open
abelriboulot opened this issue Aug 2, 2020 · 2 comments
Open

Implement beam search #2

abelriboulot opened this issue Aug 2, 2020 · 2 comments
Labels
good first issue Good for newcomers

Comments

@abelriboulot
Copy link
Owner

A next step for better generation is to implement a beam search for the generation. An example of it can be seen on the huggingface repo here, and this would need adding such a function to the GenerativeT5 model in onnxt5/models.py

@abelriboulot abelriboulot added the good first issue Good for newcomers label Aug 2, 2020
@patil-suraj
Copy link

Yes, beam search is especially useful for summarization, translation, and other fixed length generation tasks. Also all the generative results in the T5 paper are given using beam search.

And thank you for building awesome project! This is going to be super useful as people are using T5 for lot's of tasks both generative and discriminative.

@abelriboulot
Copy link
Owner Author

Thanks for the help on the generation patil, that was very useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants