Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't let image and other special html element(code) enter in descriptive short- text under title. #130

Open
chrishna1 opened this issue Jan 17, 2020 · 3 comments

Comments

@chrishna1
Copy link
Collaborator

It can create problems on a smaller device and even on larger devices too.

@chrishna1
Copy link
Collaborator Author

Maybe we can apply some kind of validation at the point of saving that if some particular HTML element is under current truncation threshold then don't save it.

@abhiabhi94 abhiabhi94 changed the title Don't let image and other special html element(code) enter in descriptive text under title. Don't let image and other special html element(code) enter in descriptive short- text under title. Jan 18, 2020
@abhiabhi94
Copy link
Owner

For images, I just added a global property for img element in css in the commit 7c87e93

max-width:100%;

This should stop images from extending beyond their parent element. I don't think there's an issue if an image appears in the short-description as long as it remains inside the parent.

Regarding code, I don't think it should be an issue?

@abhiabhi94
Copy link
Owner

The issue was closed mistakenly. A wrong issue was addressed to the commit. The commit has now been amended but Github hasn't made changes to the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants