Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title and description for password #88

Open
vansh-sardana opened this issue May 28, 2024 · 12 comments
Open

Add title and description for password #88

vansh-sardana opened this issue May 28, 2024 · 12 comments
Labels
enhancement New feature or request gssoc level1

Comments

@vansh-sardana
Copy link

Describe the bug
when we try to add the password for a website that has been already added, creates a new entry.

To Reproduce
Steps to reproduce the behavior:

  1. Login
  2. Click on 'Add new'
  3. Add two different passwords for same website
  4. Two entries will be created for same website

Expected behavior
if the same website is already listed, its password should be updated rather than creating another entry for the same.

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser : chrome
  • Version : 123.x.x.x

Additional context
Kindly assign me this issue under GSSOC'24 as a contributor. I would be eager to fix this up.

@vansh-sardana vansh-sardana added the bug Something isn't working label May 28, 2024
@vansh-sardana
Copy link
Author

@abhijeetnishal if you could look into it.

@abhijeetnishal
Copy link
Owner

Hey @vansh-sardana, it's is possible to have 2 or more passwords consider Google, it's possible to have 2 accounts and passwords can't be checked for duplicate.

@vansh-sardana
Copy link
Author

vansh-sardana commented May 29, 2024

So this website should atleast have another field for a email id/username in order to differentiate between the two fields. Only having google.com and its two passwords cant serve the purpose solely. I can work on that. @abhijeetnishal

@abhijeetnishal
Copy link
Owner

I think there is an issue #42 for this.

But I will assign it to you as you are interested working on my project.
Add title and description field as I already updated the backend, these fields are already there.

@abhijeetnishal abhijeetnishal added enhancement New feature or request gssoc level1 and removed bug Something isn't working labels May 29, 2024
@abhijeetnishal abhijeetnishal changed the title Adding the password for a website already added, creates a new entry. Add title and description for password May 29, 2024
@vansh-sardana
Copy link
Author

hello sir @abhijeetnishal , i needed help to fix one issue while setting up the postgresql.
The server does not support SSL connections.
How to fix this. i needed to run backend in order to test it.

@abhijeetnishal
Copy link
Owner

Hey @vansh-sardana, You can connect without SSL also.
But if you want to use SSL, just remove this line: ssl: { rejectUnauthorized: false },

The dbConnect code should look like:

const client = new Client({
  connectionString: connectionString,
});

Remove the code changes once done.

@saurabhbakolia
Copy link

saurabhbakolia commented Jun 2, 2024

Hey @abhijeetnishal,

I want to work on this issue,
if someone else is not working.

Thanks

@vansh-sardana vansh-sardana removed their assignment Jun 6, 2024
@abhijeetnishal
Copy link
Owner

Hey @saurabhbakolia, are you still interested in working on this?

@saurabhbakolia
Copy link

Hey @saurabhbakolia, are you still interested in working on this?

Yes, I would like to work on this.

@abhijeetnishal
Copy link
Owner

abhijeetnishal commented Jun 25, 2024

Hey @saurabhbakolia, actually I am thinking of new design as this ui doesn't fit with these requirements. So you have any UI in your mind?

@saurabhbakolia
Copy link

Hey @saurabhbakolia, actually I am thinking of new design as this ui doesn't fit with these requirements. So you have any UI in your mind?

For the entire platform ? or just for the input form?

@abhijeetnishal
Copy link
Owner

Hey @saurabhbakolia, actually I am thinking of new design as this ui doesn't fit with these requirements. So you have any UI in your mind?

For the entire platform ? or just for the input form?

For the dashboard screen only which contains the passwords

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc level1
Projects
None yet
Development

No branches or pull requests

3 participants