Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Acceptors] Decouple Threadless pool setup/teardown from acceptor pool #706

Closed
abhinavsingh opened this issue Nov 8, 2021 · 0 comments · Fixed by #714
Closed

[Acceptors] Decouple Threadless pool setup/teardown from acceptor pool #706

abhinavsingh opened this issue Nov 8, 2021 · 0 comments · Fixed by #714
Assignees

Comments

@abhinavsingh
Copy link
Owner

Is your feature request related to a problem? Please describe.
Currently, --num-workers is shared by both acceptors and threadless process pool. In a real world scenario, users may need to configure different number of acceptors vs threadless processes. Currently, there is a threadless process dedicated for each acceptor process.

Describe the solution you'd like

  1. Add a --num-acceptors flag
  2. Decouple threadless pool setup/teardown from acceptor pool class

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
This might be necessary if you are not expecting too many concurrent client requests but each request is a heavy request (e.g. file upload / file download).

@abhinavsingh abhinavsingh self-assigned this Nov 8, 2021
@abhinavsingh abhinavsingh added the Good First Issue Issues for new contributors to pick-up label Nov 8, 2021
@abhinavsingh abhinavsingh removed the Good First Issue Issues for new contributors to pick-up label Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant