From 6737bcecb6b163060807006e7f21cdfa342cdf09 Mon Sep 17 00:00:00 2001 From: Abhinav Singh Date: Mon, 8 Nov 2021 01:13:05 +0530 Subject: [PATCH 1/6] Trigger workflows only when necessary file changes are detected --- .github/workflows/test-dashboard.yml | 8 +++++++- .github/workflows/test-library.yml | 10 +++++++++- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test-dashboard.yml b/.github/workflows/test-dashboard.yml index 172e27a4f7..3070e7fee9 100644 --- a/.github/workflows/test-dashboard.yml +++ b/.github/workflows/test-dashboard.yml @@ -1,7 +1,13 @@ --- name: dashboard -on: [push, pull_request] # yamllint disable-line rule:truthy +on: + push: + paths: + - 'dashboard/**' + pull_request: + paths: + - 'dashboard/**' jobs: build: diff --git a/.github/workflows/test-library.yml b/.github/workflows/test-library.yml index 07c4decf9b..0afef59c77 100644 --- a/.github/workflows/test-library.yml +++ b/.github/workflows/test-library.yml @@ -1,7 +1,15 @@ --- name: lib -on: [push, pull_request] # yamllint disable-line rule:truthy +on: + push: + paths: + - 'proxy/**' + - 'tests/**' + pull_request: + paths: + - 'proxy/**' + - 'tests/**' concurrency: group: >- From d0a3067d65d3fc3a8fe900e10fc40eb5432dcab6 Mon Sep 17 00:00:00 2001 From: Abhinav Singh Date: Mon, 8 Nov 2021 01:16:46 +0530 Subject: [PATCH 2/6] Address yamllint --- .github/workflows/test-dashboard.yml | 6 +++--- .github/workflows/test-library.yml | 10 +++++----- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/test-dashboard.yml b/.github/workflows/test-dashboard.yml index 3070e7fee9..b07f98773b 100644 --- a/.github/workflows/test-dashboard.yml +++ b/.github/workflows/test-dashboard.yml @@ -1,13 +1,13 @@ --- name: dashboard -on: +on: # yamllint disable-line rule:truthy push: paths: - - 'dashboard/**' + - 'dashboard/**' pull_request: paths: - - 'dashboard/**' + - 'dashboard/**' jobs: build: diff --git a/.github/workflows/test-library.yml b/.github/workflows/test-library.yml index 0afef59c77..d1b97585d4 100644 --- a/.github/workflows/test-library.yml +++ b/.github/workflows/test-library.yml @@ -1,15 +1,15 @@ --- name: lib -on: +on: # yamllint disable-line rule:truthy push: paths: - - 'proxy/**' - - 'tests/**' + - 'proxy/**' + - 'tests/**' pull_request: paths: - - 'proxy/**' - - 'tests/**' + - 'proxy/**' + - 'tests/**' concurrency: group: >- From 155362ccca8c3f38014f95f2c0c6b284a5b87a21 Mon Sep 17 00:00:00 2001 From: Abhinav Singh Date: Mon, 8 Nov 2021 01:17:49 +0530 Subject: [PATCH 3/6] Trigger workflows even when workflow file itself is changed --- .github/workflows/test-dashboard.yml | 2 ++ .github/workflows/test-library.yml | 2 ++ 2 files changed, 4 insertions(+) diff --git a/.github/workflows/test-dashboard.yml b/.github/workflows/test-dashboard.yml index b07f98773b..42dca52df3 100644 --- a/.github/workflows/test-dashboard.yml +++ b/.github/workflows/test-dashboard.yml @@ -5,9 +5,11 @@ on: # yamllint disable-line rule:truthy push: paths: - 'dashboard/**' + - '.github/workflows/test-dashboard.yml' pull_request: paths: - 'dashboard/**' + - '.github/workflows/test-dashboard.yml' jobs: build: diff --git a/.github/workflows/test-library.yml b/.github/workflows/test-library.yml index d1b97585d4..311f0fc7ba 100644 --- a/.github/workflows/test-library.yml +++ b/.github/workflows/test-library.yml @@ -6,10 +6,12 @@ on: # yamllint disable-line rule:truthy paths: - 'proxy/**' - 'tests/**' + - '.github/workflows/test-library.yml' pull_request: paths: - 'proxy/**' - 'tests/**' + - '.github/workflows/test-library.yml' concurrency: group: >- From 913694bb54d13915423540dcfe69dcf23ae27d32 Mon Sep 17 00:00:00 2001 From: Abhinav Singh Date: Mon, 8 Nov 2021 01:21:52 +0530 Subject: [PATCH 4/6] Also include `examples` directory, may be one day we will have tests for them --- .github/workflows/test-library.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/test-library.yml b/.github/workflows/test-library.yml index 311f0fc7ba..b9e46b091c 100644 --- a/.github/workflows/test-library.yml +++ b/.github/workflows/test-library.yml @@ -6,11 +6,13 @@ on: # yamllint disable-line rule:truthy paths: - 'proxy/**' - 'tests/**' + - 'examples/**' - '.github/workflows/test-library.yml' pull_request: paths: - 'proxy/**' - 'tests/**' + - 'examples/**' - '.github/workflows/test-library.yml' concurrency: From d586ba7f862d55fb2da10bbb1be20ac0ab6eb055 Mon Sep 17 00:00:00 2001 From: Abhinav Singh Date: Mon, 8 Nov 2021 01:24:01 +0530 Subject: [PATCH 5/6] `brew` and `docker` workflows must also only execute for python file changes. This will skip them for pure README.md changes --- .github/workflows/test-brew.yml | 14 +++++++++++++- .github/workflows/test-docker.yml | 14 +++++++++++++- 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test-brew.yml b/.github/workflows/test-brew.yml index 7c31ce1f50..2390279246 100644 --- a/.github/workflows/test-brew.yml +++ b/.github/workflows/test-brew.yml @@ -1,7 +1,19 @@ --- name: brew -on: [push, pull_request] # yamllint disable-line rule:truthy +on: # yamllint disable-line rule:truthy + push: + paths: + - 'proxy/**' + - 'tests/**' + - 'examples/**' + - '.github/workflows/test-brew.yml' + pull_request: + paths: + - 'proxy/**' + - 'tests/**' + - 'examples/**' + - '.github/workflows/test-brew.yml' jobs: build: diff --git a/.github/workflows/test-docker.yml b/.github/workflows/test-docker.yml index 2d81652db7..bacd170586 100644 --- a/.github/workflows/test-docker.yml +++ b/.github/workflows/test-docker.yml @@ -1,7 +1,19 @@ --- name: docker -on: [push, pull_request] # yamllint disable-line rule:truthy +on: # yamllint disable-line rule:truthy + push: + paths: + - 'proxy/**' + - 'tests/**' + - 'examples/**' + - '.github/workflows/test-docker.yml' + pull_request: + paths: + - 'proxy/**' + - 'tests/**' + - 'examples/**' + - '.github/workflows/test-docker.yml' jobs: build: From 26b4e6cc703a26bdad9b8d73dee49964cf627bf8 Mon Sep 17 00:00:00 2001 From: Abhinav Singh Date: Mon, 8 Nov 2021 01:30:49 +0530 Subject: [PATCH 6/6] Execute `lib` workflows for package artifact changes --- .github/workflows/test-brew.yml | 10 ++++++++++ .github/workflows/test-docker.yml | 10 ++++++++++ .github/workflows/test-library.yml | 8 ++++++++ 3 files changed, 28 insertions(+) diff --git a/.github/workflows/test-brew.yml b/.github/workflows/test-brew.yml index 2390279246..a0dd449d5f 100644 --- a/.github/workflows/test-brew.yml +++ b/.github/workflows/test-brew.yml @@ -7,13 +7,23 @@ on: # yamllint disable-line rule:truthy - 'proxy/**' - 'tests/**' - 'examples/**' + - 'requirements*' + - 'setup.cfg' + - 'version-check.py' + - 'MANIFEST.in' - '.github/workflows/test-brew.yml' + - 'helper/homebrew/**' pull_request: paths: - 'proxy/**' - 'tests/**' - 'examples/**' + - 'requirements*' + - 'setup.cfg' + - 'version-check.py' + - 'MANIFEST.in' - '.github/workflows/test-brew.yml' + - 'helper/homebrew/**' jobs: build: diff --git a/.github/workflows/test-docker.yml b/.github/workflows/test-docker.yml index bacd170586..ee30eaa244 100644 --- a/.github/workflows/test-docker.yml +++ b/.github/workflows/test-docker.yml @@ -7,13 +7,23 @@ on: # yamllint disable-line rule:truthy - 'proxy/**' - 'tests/**' - 'examples/**' + - 'requirements*' + - 'setup.cfg' + - 'version-check.py' + - 'MANIFEST.in' - '.github/workflows/test-docker.yml' + - 'Dockerfile' pull_request: paths: - 'proxy/**' - 'tests/**' - 'examples/**' + - 'requirements*' + - 'setup.cfg' + - 'version-check.py' + - 'MANIFEST.in' - '.github/workflows/test-docker.yml' + - 'Dockerfile' jobs: build: diff --git a/.github/workflows/test-library.yml b/.github/workflows/test-library.yml index b9e46b091c..702ee119a1 100644 --- a/.github/workflows/test-library.yml +++ b/.github/workflows/test-library.yml @@ -7,12 +7,20 @@ on: # yamllint disable-line rule:truthy - 'proxy/**' - 'tests/**' - 'examples/**' + - 'requirements*' + - 'setup.cfg' + - 'version-check.py' + - 'MANIFEST.in' - '.github/workflows/test-library.yml' pull_request: paths: - 'proxy/**' - 'tests/**' - 'examples/**' + - 'requirements*' + - 'setup.cfg' + - 'version-check.py' + - 'MANIFEST.in' - '.github/workflows/test-library.yml' concurrency: