Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvise logging for Channel connection timeout on platform code #19

Open
tiholic opened this issue Jul 21, 2020 · 3 comments
Open

Improvise logging for Channel connection timeout on platform code #19

tiholic opened this issue Jul 21, 2020 · 3 comments
Labels
blocked-by-ably We can't proceed until something under our direct control, in a different codebase, happens.

Comments

@tiholic
Copy link
Contributor

tiholic commented Jul 21, 2020

Why?

I've been calling Realtime#channels#get#attach without calling Realtime#connect first
This iteratively tries to attach to the channel and on timeout, RealtimeChannelStatus will be set as suspended. I wasn't sure until paddybyers asked me whether I connected to the realtime instance in the first place!

Suggestion

Improvise VERBOSE/INFO logging on timeout and if realtime instance status is not connected to show:

attach timeout, realtime instance is not connected
retrying attach

NOTE: This enhancement must be done on platform code ably-java and ably-cocoa

┆Issue is synchronized with this Jira Task by Unito

@QuintinWillison
Copy link
Contributor

This suggestion is one possible solution. There may be others (e.g. fail faster).

See internal conversation.

@ikbalkaya
Copy link
Contributor

Hmm. I just went through conversation and there doesn't seem to be a decision on how to tackle this. Considering this is an issue rooting from the platform implementations I would say they should be handled there. WDYT @QuintinWillison ? If so I can create issues for corresponding platforms

@QuintinWillison
Copy link
Contributor

@ikbalkaya yes, please create platform issues and link them back to this issue. This issue should remain open until those dependencies have been updated here.

@QuintinWillison QuintinWillison added blocked-by-ably We can't proceed until something under our direct control, in a different codebase, happens. and removed blocked-by-ably-cocoa labels Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked-by-ably We can't proceed until something under our direct control, in a different codebase, happens.
Development

No branches or pull requests

3 participants