Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code that's supporting older platforms (in v2) #1538

Closed
lawrence-forooghian opened this issue Dec 6, 2023 · 3 comments · Fixed by #1629
Closed

Remove code that's supporting older platforms (in v2) #1538

lawrence-forooghian opened this issue Dec 6, 2023 · 3 comments · Fixed by #1629
Assignees

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Dec 6, 2023

In particular, owenpearson said there is a bunch of stuff in utils.ts that can be replaced by built-in ES stuff. (Once we've done #1537 we'll know what version of ES we're targeting.)

There may also be other stuff that's supporting older browsers; again, waiting for outcome of #1537 to know what we can remove.

┆Issue is synchronized with this Jira Task by Unito

@lawrence-forooghian lawrence-forooghian changed the title Remove code that's supporting older platforms Remove code that's supporting older platforms (in v2) Dec 6, 2023
Copy link

sync-by-unito bot commented Dec 6, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3987

@VeskeR
Copy link
Contributor

VeskeR commented Feb 3, 2024

Based on DR accepted in #1537, the code to remove would include:

  • IE specific code (can be found by searching for words IE, MSIE, IE[\d+], IE [\d+], Internet Explorer)
  • functions/class methods polyfills that are natively supported by ES2017 (Array.filter, Array.map etc if we don't use it already. mostly found in utils.ts
  • old browser versions specific code that we don't support anymore (old versions of Chrome, Firefox, Safari etc)

@VeskeR
Copy link
Contributor

VeskeR commented Feb 28, 2024

Done in #1629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants