Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overly permissive egg fragment parsing in URL requirements #7

Open
woodruffw opened this issue Oct 31, 2022 · 1 comment
Open

Overly permissive egg fragment parsing in URL requirements #7

woodruffw opened this issue Oct 31, 2022 · 1 comment

Comments

@woodruffw
Copy link

First of all, thanks for maintaining this parser! It's been invaluable within pip-audit.

Per pypa/pip#11567: #egg=packagename==packageversion isn't actually valid, but this parser (and some others) accept it.

I'll wait for a resolution on that pip issue first, but I'm happy to submit a PR here that brings this library into compatibility with whatever pip decides 🙂

@pombredanne
Copy link
Member

@woodruffw re:

First of all, thanks for maintaining this parser! It's been invaluable within pip-audit.

That's great! and what you are doing with "pip-audit" is wonderful.

Per pypa/pip#11567: #egg=packagename==packageversion isn't actually valid, but this parser (and some others) accept it.

I'll wait for a resolution on that pip issue first, but I'm happy to submit a PR here that brings this library into compatibility with whatever pip decides Please do: this would be great

FWIW, this parser is also heavily used in all the scancode projects and related in this org scanning eventually billions of requirements so this is going to be there for as long as there are requirements files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants