Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Upgrade to Cypress 4 #153

Closed
warpech opened this issue Feb 8, 2020 · 4 comments
Closed

[Feature] Upgrade to Cypress 4 #153

warpech opened this issue Feb 8, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@warpech
Copy link

warpech commented Feb 8, 2020

Current behavior:

This plugin requires Cypress 3.x.x according to

"cypress": "^3.0.0"
.

Desired behavior:

I wish the plugin is updated to work with the current version of Cypress, which is 4.0.1.

Thanks for a great plugin! 👋

@warpech warpech added the enhancement New feature or request label Feb 8, 2020
@abramenal
Copy link
Owner

Hi @warpech
Thanks for submitting the issue!

I am really happy that the plugin went so widely used among the community 😃
With regards to new version I expect a bunch of issues either related to v4 itself or cross-browser compatibility (like #154)

So I would expect having proper tests and fixing all ongoing issues until the end of February.

Stay tuned! 🌟

@valscion
Copy link

For us, all of our tests, including the ones that used cypress-file-upload to upload an image to a form using https://www.dropzonejs.com/, worked flawlessly with Firefox and Cypress v4 ☺️

We merely ignore the warning generated by the peer dependency requirement of cypress-file-upload for now

@jimmyandrade
Copy link

jimmyandrade commented Feb 20, 2020

Given I have:

  • yarn version 1.21.1;
  • cypress-file-upload version 3.5.3;
  • cypress version 4.0.2.

When I run yarn install

Then this is Terminal output:

[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
[4/5] 🔗  Linking dependencies...
warning " > cypress-file-upload@3.5.3" has incorrect peer dependency "cypress@^3.0.0".
[5/5] 🔨  Building fresh packages...

success Saved lockfile.
✨  Done in 21.57s.

Process finished with exit code 0

But this should be the Terminal output:

[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
[4/5] 🔗  Linking dependencies...
[5/5] 🔨  Building fresh packages...

success Saved lockfile.
✨  Done in [...]s.

Process finished with exit code 0

For now I'm ignoring the warning (like @valscion said)...
...but it would be better if this warning does not appear.

@abramenal
Copy link
Owner

Hi @warpech @valscion @jimmyandrade,
it's now fixed with v4 release, please check out!

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants