Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve search for Users, Things, Channels, and Groups #2287

Closed
dborovcanin opened this issue Jun 12, 2024 · 0 comments · Fixed by #2288, #2305 or #2315
Closed

Improve search for Users, Things, Channels, and Groups #2287

dborovcanin opened this issue Jun 12, 2024 · 0 comments · Fixed by #2288, #2305 or #2315
Assignees
@nyagamunene
Labels
enhancement

Comments

@dborovcanin
Copy link
Collaborator

dborovcanin commented Jun 12, 2024 •
edited
Loading

We need to enable backend support for filtering by name. In the initial implementation here

magistrala/pkg/clients/postgres/clients.go

Line 194 in 3355332

sq, tq := constructSearchQuery(pm)
we return id, name, creation and update time, but we need only id and name. Let's also rename to SearchBasicInfo or something similar to avoid association with List (RetrieveAll) operations. We also need it across different services for Thing and Channels (when assigning to Channel or filtering Things on the UI, for example).
@arvindh123 arvindh123 changed the title Improve search for Things, Users, and Channels Improve search for Users, Things, Channels, and Groups Jun 12, 2024
@nyagamunene nyagamunene mentioned this issue Jun 13, 2024
Merged
This was referenced Jun 23, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nyagamunene nyagamunene

Labels
enhancement
Projects
Magistrala
Status: ✅ Done
Milestone
No milestone
2 participants
@dborovcanin @nyagamunene