Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task to remove prototype extensions #8

Closed
tim-evans opened this issue Mar 27, 2015 · 8 comments
Closed

Add task to remove prototype extensions #8

tim-evans opened this issue Mar 27, 2015 · 8 comments

Comments

@tim-evans
Copy link
Collaborator

Since this seems to becoming the default, having a task to remove decorators that use prototypes would be really nice :3

See:
ember-cli/ember-cli#3645
emberjs/guides#110

@stefanpenner
Copy link
Collaborator

ya good idea, this should be a relatively simple transformation.

@kamal
Copy link
Collaborator

kamal commented Mar 30, 2015

I pushed a PR to transform CP and observers #10

Next steps would be to transform more prototype extensions like

'hello %@'.fmt('world')

Is there a complete list somewhere?

@tim-evans
Copy link
Collaborator Author

@kamal I think fmt should be removed and quasi literals are used. But that's up to the core team.

@stefanpenner
Copy link
Collaborator

@tim-evans I would be on board with that. If someone opens an issue I'll bring it up this next meeting for discussion

@tim-evans
Copy link
Collaborator Author

@stefanpenner woot

@abuiles
Copy link
Owner

abuiles commented Mar 30, 2015

Just released the new command thanks to @kamal!

npm install ember-watson@0.2.0 --save-dev
ember convert-prototype-extensions

@abuiles abuiles closed this as completed Mar 30, 2015
@abuiles abuiles reopened this Mar 30, 2015
@abuiles
Copy link
Owner

abuiles commented Mar 30, 2015

Actually leaving open until we have figured how to transform other parts of the extensions.

@tim-evans
Copy link
Collaborator Author

Supporting on would be nice too :)

@abuiles abuiles closed this as completed Jun 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants