Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split ttree into a re-usable module. #316

Merged
merged 3 commits into from
Jun 8, 2024
Merged

Split ttree into a re-usable module. #316

merged 3 commits into from
Jun 8, 2024

Conversation

burak
Copy link
Contributor

@burak burak commented Sep 20, 2023

No description provided.

burak added a commit to Perl-Hadoop/App-Oozie that referenced this pull request Sep 26, 2023
There is an actual MR request for TT, but it's uncertain if and when
that would be accepted. Until then (if ever) the fork will exist.

See abw/Template2#316
@atoomic
Copy link
Collaborator

atoomic commented Apr 28, 2024

This LGTM, note that until now all packages were shipped inside the Template/* directory and with this change this would add App/Template/ directory. Would not Template/App or Template/Tool be a better location?

@burak
Copy link
Contributor Author

burak commented May 9, 2024

This LGTM, note that until now all packages were shipped inside the Template/* directory and with this change this would add App/Template/ directory. Would not Template/App or Template/Tool be a better location?

I was just following the CPAN conventions, but indeed it can be renamed. I'll check that soon.

@burak
Copy link
Contributor Author

burak commented Jun 7, 2024

Now renamed.

@atoomic atoomic merged commit f6347e7 into abw:master Jun 8, 2024
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants