Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update react version / npm packages #34

Closed
acarteas opened this issue Oct 10, 2020 · 2 comments
Closed

Update react version / npm packages #34

acarteas opened this issue Oct 10, 2020 · 2 comments
Assignees
@itravers @abchilders
Labels
bug Something isn't working

Comments

@acarteas
Copy link
Owner

Running npm update, I get:

found 1666 vulnerabilities (1279 low, 24 moderate, 362 high, 1 critical)

Seems like the react build needs to be updated.
@acarteas acarteas added the bug Something isn't working label Oct 10, 2020
@itravers
Copy link
Collaborator

I've created the react-update branch to work on this.
It's pulled from the current master branch.

@abchilders abchilders mentioned this issue Oct 13, 2020
Merged
@abchilders
Copy link
Collaborator

abchilders commented Oct 13, 2020 •
edited
Loading

Just opened PR #35. There are 308 remaining low severity vulnerabilities, all of which have to do with jest using an old version of minimist. There is an advisory for this vulnerability, and the issue regarding this on jest's repository remains open for now.

EDIT: react-scripts also uses an older version of webpack; patches of that package fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@itravers itravers

@abchilders abchilders

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@itravers @acarteas @abchilders