Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation and examples of Authenticating are diferent #816

Closed
gnunesmoura opened this issue Sep 26, 2019 · 5 comments · Fixed by #1258
Closed

Documentation and examples of Authenticating are diferent #816

gnunesmoura opened this issue Sep 26, 2019 · 5 comments · Fixed by #1258

Comments

@gnunesmoura
Copy link

At the authenticating-resolvers the docs uses this call
authenticated(AccountsServer, function)

At the authenticated doc it show the method signature as
authenticated(function)

I think that the right one is the authenticated documentation, could you change the exemples to make easier to new users use the API?

@pradel
Copy link
Member

pradel commented Sep 27, 2019

Yeah, you are right!
Pull requests welcome to fix the documentation :)

@deathemperor
Copy link

There're also some other issues with the docs, right at the getting started. This code doesn't work:

import accountsBoost from `@accounts/boost`;
(async () => {
  const accounts = await accountsBoost({
    tokenSecret: 'your secret'
  }).listen({
    port: 4003
  });
})();

Also, @accounts/oauth-facebook doesn't exist.

@gezquinndesign
Copy link
Contributor

@pradel I'm happy to submit a PR for both of these issues if no one else is looking at them?

@JoJ123
Copy link
Contributor

JoJ123 commented Sep 15, 2020

I had the same issue.
PR raised: #1056

@gezquinndesign
Copy link
Contributor

Hello all,

Sorry I'm so late (!) in actually getting round to this! I see JoJ123 fixed the original issue. I tried looking at the issue raised by deathemperor but can't see a good working example of the minimal code required to start an @accounts/boost server. Any pointers?

@darkbasic darkbasic added the 1.0 label Nov 22, 2023
@darkbasic darkbasic added this to the 1.0 milestone Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants