Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting scripts for use in CI #2

Closed
caesarsol opened this issue Dec 15, 2016 · 4 comments
Closed

Add linting scripts for use in CI #2

caesarsol opened this issue Dec 15, 2016 · 4 comments

Comments

@caesarsol
Copy link
Contributor

emulate this:

"scripts": {
    "lint": "node node_modules/eslint/bin/eslint.js src/",
    "lint:errors": "node node_modules/eslint/bin/eslint.js --quiet src/"
}
@markov00
Copy link
Contributor

markov00 commented May 17, 2017

  • Add lint only at pre-commit

  • Add lint only on diff files

@marcofugaro
Copy link
Contributor

marcofugaro commented Aug 10, 2017

@marcofugaro
Copy link
Contributor

Added lint command in 8b82128 which lints only changed files in src/ folder.

Sould we also add the (removable) hooks on pre-commit which prevents commiting if there are any warnings? Using husky

What do you say @accurat/developers?

@marcofugaro
Copy link
Contributor

Closed in #40 .

Linting in pre-commit seems too strict. If someone wishes to, he can enable it per project using husky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants