Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications for Applications created by AppSource #5

Open
aceamarco opened this issue Jul 16, 2021 · 0 comments
Open

Notifications for Applications created by AppSource #5

aceamarco opened this issue Jul 16, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@aceamarco
Copy link
Collaborator

Summary

We can utilize the pre-existing Notifications Engine to add a notifications field to the AppSource instance — so that Dev Teams can be notified about what is happening with their applications.

Motivation

Dev teams can stay informed about the state of their Applications through notifications.

Proposal

We add a optional notifications.channel field to the AppSource instance that will add an annotation to the Application within the Application Create Request made by the controller.

Here is an example AppSource instance manifest:

apiVersion: argoproj.io/v1alpha1
kind: AppSource
metadata:
  name: appsource-sample1
  namespace: my-project-us-west-2
spec:
  path: kustomize-guestbook
 # New Field
  notifications.channel: my_channel
  repoURL: https://github.com/argoproj/argocd-example-apps

This is the Application it would create:

apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  annotations:
    # New annotation
    notifications.argoproj.io/subscribe.on-sync-succeeded.slack: my_channel
. . .
@aceamarco aceamarco added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant