Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookoff sound and visuals desynchronize #4900

Closed
theYoursTruly opened this issue Feb 14, 2017 · 3 comments · Fixed by #4990
Closed

Cookoff sound and visuals desynchronize #4900

theYoursTruly opened this issue Feb 14, 2017 · 3 comments · Fixed by #4990
Labels
kind/bug
Milestone
3.9.1

Comments

@theYoursTruly
Copy link
Contributor

theYoursTruly commented Feb 14, 2017 •
edited
Loading

Arma 3 Version: 1.66 (stable)
CBA Version: 3.1.2 (stable)
ACE3 Version: 3.x.x (dev + c0c4166)

Mods:

  • @CBA_A3
  • @ace

Description:

  • Sound and visual effects have a random delay/desync on the dedicated server. Visualization of the problem: YouTube

Steps to reproduce:

  • Fire at an armored vehicle with an AT to cause a cookoff.

Where did the issue occur?

  • Dedicated

Placed Modules:

  • None

RPT log file:
@jonpas jonpas added this to the 3.9.1 milestone Feb 14, 2017
@rebelvg
Copy link
Contributor

rebelvg commented Mar 4, 2017

Probably say3d can be used. It will stop the sound if the object it's attached to is destroyed and it will follow the object if it moves around.

@commy2
Copy link
Contributor

commy2 commented Mar 4, 2017

This commit broke it by introducing random delays that are calculated on each machine independently:
059980b

@thojkooi thojkooi modified the milestones: 3.10.0, 3.9.1 Mar 13, 2017
@commy2
Copy link
Contributor

commy2 commented Mar 14, 2017

https://github.com/acemod/ACE3/blob/master/addons/cookoff/functions/fnc_cookOff.sqf#L135-L137
https://github.com/acemod/ACE3/blob/master/addons/cookoff/functions/fnc_cookOffBox.sqf#L74-L76

Just need to remove these random

Because the function runs on every machine, everyone rolls a different number.
Sound and explosion is done by the server, but visuals by everyone (since related commands have local effects).

commy2 added a commit that referenced this issue Mar 14, 2017
@commy2
Fix cookoff desynch, fix #4900
2334d50 
Randomness would be calculated on every machine, but only vehicle explosion and sound are done by the server. Smoke, light and fire sfx are done by each client.
@commy2 commy2 mentioned this issue Mar 14, 2017
Merged
@PabstMirror PabstMirror modified the milestones: 3.9.1, 3.10.0 Mar 15, 2017
@bux bux closed this as completed in #4990 Mar 15, 2017
bux pushed a commit that referenced this issue Mar 15, 2017
@commy2 @bux
Fix cookoff desynch, fix #4900
371caaa 
Randomness would be calculated on every machine, but only vehicle explosion and sound are done by the server. Smoke, light and fire sfx are done by each client.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
3.9.1
Development

Successfully merging a pull request may close this issue.

Fix cookoff desynch acemod/ACE3
6 participants
@thojkooi @commy2 @jonpas @PabstMirror @theYoursTruly @rebelvg