Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map light doesn't detect laser/light attachments #7130

Closed
dedmen opened this issue Aug 10, 2019 · 9 comments · Fixed by #7578
Closed

Map light doesn't detect laser/light attachments #7130

dedmen opened this issue Aug 10, 2019 · 9 comments · Fixed by #7578
Labels
help wanted kind/enhancement Release Notes: **IMPROVED:**
Milestone

Comments

@dedmen
Copy link
Contributor

dedmen commented Aug 10, 2019

Arma 3 Version: 1.94 stable
CBA Version: 3.12.0.190708 stable
ACE3 Version: 3.12.6 stable

Mods:

- CBA_A3
- ace
- TONS OF OTTHER MODS YA FUQ

Description:

  • You cannot use a Laser/Light weapon attachment as Maplight if it's not currently switched to Light mod.

Steps to reproduce:

  • Take laser/light attachment onto gun
  • Can't use it as maplight

Where did the issue occur?

  • Dedicated / Self-Hosted Multiplayer / Singleplayer / Editor (Singleplayer) / Editor (Multiplayer) / Virtual Arsenal

Additional information:

  • Cuz it checks only the current attachment, which is currently a laser only. Thought as you can switch directly over, it would make sense that you can just switch it. Instead of first having to switch to your pistol, then switch to flashlight, then switch back to main weapon, then go to map and then enable the light.

RPT log file:
N/A

@commy2
Copy link
Contributor

commy2 commented Aug 11, 2019

just switch to flashlight mode you lazy bum

@stale
Copy link

stale bot commented Feb 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@dedmen
Copy link
Contributor Author

dedmen commented Feb 10, 2020

Why BI's fault?
Its our fault that maplight doesn't check if current weapon attachment, is CBA switchable, and whether the switchable states have light support.

Thats rather trivial to fix.
When checking for maplight, check if attachment has switching, and check the other states for light.
We don't need to actually switch the mode over I think.

Why won't do? I think this is better as a "Help wanted"

@commy2
Copy link
Contributor

commy2 commented Feb 10, 2020

just switch to flashlight mode you lazy bum

@jonpas
Copy link
Member

jonpas commented Feb 10, 2020

This is terrible UX, user should at least know it's possible with the item they have.

@dedmen
Copy link
Contributor Author

dedmen commented Feb 10, 2020

just switch to flashlight mode you lazy bum

Sure. This definitely doesn't have any priority. But I still don't think it makes sense to close this, as this is definitely fixable.

@veteran29
Copy link
Member

I agree with Dedmen, reopen? 😬

@commy2
Copy link
Contributor

commy2 commented Feb 10, 2020

^ helper function

@dedmen
Copy link
Contributor Author

dedmen commented Feb 11, 2020

^ helper function

still needs implementation of that in ACE then. Please reopen the ticket

@commy2 commy2 reopened this Feb 11, 2020
@jonpas jonpas added this to the Backlog milestone Mar 7, 2020
@jonpas jonpas added the kind/enhancement Release Notes: **IMPROVED:** label Mar 7, 2020
@PabstMirror PabstMirror modified the milestones: Backlog, 3.13.2 Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants