Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maptools - Fix gps detection #10007

Merged
merged 2 commits into from
May 21, 2024
Merged

Maptools - Fix gps detection #10007

merged 2 commits into from
May 21, 2024

Conversation

PabstMirror
Copy link
Contributor

Fix #10006
Ref #9885

I don't think we even need the itemType check as only gps/uav should fit in that slot?

@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label May 18, 2024
@PabstMirror PabstMirror added this to the 3.18.0 milestone May 18, 2024
@johnb432
Copy link
Contributor

What about vehicle based GPS? #9885 gave that option.

I have this code which takes that into account.

private _panels = flatten (_unit infoPanelComponents "left");
private _index = _panels find "MinimapDisplayComponent";

_index != -1 && {_panels select (_index + 1)}

Co-Authored-By: johnb432 <58661205+johnb432@users.noreply.github.com>
Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to release a 3.17.2?

@PabstMirror PabstMirror merged commit a316080 into master May 21, 2024
5 checks passed
@PabstMirror PabstMirror deleted the gpstype branch May 21, 2024 23:26
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
* Maptools - Fix gps detection

* Use `infoPanelComponents`

Co-Authored-By: johnb432 <58661205+johnb432@users.noreply.github.com>

---------

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Left panel GPS always open after closing map
3 participants