Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing 25.0] tools/get_dicom_files.pl #937

Closed
32 tasks done
cmadjar opened this issue Apr 20, 2023 · 2 comments
Closed
32 tasks done

[Testing 25.0] tools/get_dicom_files.pl #937

cmadjar opened this issue Apr 20, 2023 · 2 comments

Comments

@cmadjar
Copy link
Collaborator

cmadjar commented Apr 20, 2023

Valid usage tested:

  • name: one name, multiple names
  • type: one type, mutliple types
  • outdir: /data/tmp
  • outfile: a new name
  • id: pscid, candid, pscid_candid or candid_pscid
  • profile: prod

Errors tested:

  • no name and no type
  • no profile
  • 1 wrong name
  • 2 wrong names
  • 1 wrong type
  • 2 wrong types
  • wrong profile
  • wrong id
  • Non-existent outdir

Expected default values:

  • no id -> candid
  • no outdir -> env TMPDIR (/data/tmp)
  • no outfile -> current folder, dicoms.tar.gz
  • no type -> all types for selected 1 name
  • no type -> all types for selected 2 names
  • no name -> all name for selected 1 type
  • no name -> all name for selected 2 types

Some nominal usages (profile + ...):

  • 1 name + 1 type
  • 1 name + 2 types
  • 2 names + 1 type
  • 2 names + 2 types
  • 1 good name + 1 wrong name (should ignore the wrong one, order does not matter)
  • 1 good type + 1 wrong type (should ignore the wrong one, order does not matter)
  • 1 name+ 1 type + candid (default, but explicit)
  • 1 name+ 1 type + pscid
  • 1 name+ 1 type + pscid_candid
  • 1 name+ 1 type + candid_pscid

Minor issue: #1008
Known issue not fixed in this release: #718

@cmadjar cmadjar changed the title tools/get_dicom_files.pl [Testing 25.0] tools/get_dicom_files.pl Apr 20, 2023
@regisoc
Copy link
Contributor

regisoc commented Apr 20, 2023

EDIT: put into description.

@regisoc
Copy link
Contributor

regisoc commented Apr 20, 2023

@cmadjar only one point for this script, else LGTM

@laemtl laemtl added the PR sent label Jun 20, 2023
@laemtl laemtl assigned nicolasbrossard and unassigned regisoc Jul 10, 2023
@cmadjar cmadjar closed this as completed Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants