Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename candidate CenterID to RegistrationCenterID #341

Conversation

cmadjar
Copy link
Collaborator

@cmadjar cmadjar commented Nov 12, 2018

Brief summary of changes

This PR rename the CenterID field column of the candidate table to RegistrationCenterID, which will correspond to the CenterID at which the candidate was first registered. This should never be changed for a given candidate.

Associated LORIS PR:

aces/Loris#4078

This resolves issue...

To test this change...

Copy link
Collaborator

@nicolasbrossard nicolasbrossard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Shouldn't we tag this PR as "Blocked" though since it depends on its associated PR on the LORIS side?

@cmadjar
Copy link
Collaborator Author

cmadjar commented Nov 12, 2018

@nicolasbrossard Added the labels. Weird, I thought I added them but I guess they did not stick around. Thanks for reviewing the PR!!

@cmadjar cmadjar force-pushed the rename_candidate_CenterID_to_RegistrationCenterID branch from a6a7f78 to e923db6 Compare January 21, 2019 19:23
@cmadjar
Copy link
Collaborator Author

cmadjar commented Feb 4, 2019

The LORIS branch has been merged so we can now merge this one too. Yeah!

@cmadjar cmadjar merged commit 9a07957 into aces:major Feb 4, 2019
@cmadjar cmadjar deleted the rename_candidate_CenterID_to_RegistrationCenterID branch February 4, 2019 16:56
@cmadjar cmadjar added this to the 21.0 milestone Jun 26, 2019
@cmadjar cmadjar removed the Blocked Merge it and you die label Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants