Header (0020,0032) now only checked when -slicepos is passed on the command line #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmadjar
reviewed
Dec 12, 2018
dicom-archive/get_dicom_info.pl
Outdated
| @@ -136,7 +136,8 @@ =head2 Methods | |||
| my(@position) = | |||
| # ImagePositionPatient (0x0020, 0x0032) | |||
| &convert_coordinates(&split_dicom_list(&trim($dicom->value('0020', '0032')))); | |||
| if (scalar(@position) != 3) { | |||
| my $computeSlicePos = grep($_->[1] eq 'slicepos', @Variables); | |||
| if (scalar(@position) != 3 && $computeSlicePos) { | |||
| warn "Warning: The file: $filename is not DICOM!\n"; | |||
There was a problem hiding this comment.
@nicolasbrossard I wonder if we should not update the warning error to something clearer. Like "Warning: the file $filename is either not DICOM or does not contain any value for DICOM header (0020,0032)"
There was a problem hiding this comment.
@cmadjar Since header (0020,0032) is not mandatory, I vote for changing the warning to
"DICOM header (0020,0032) not found in $filename: slice position cannot be computed. Skipping file.\n"
What do you think?
cmadjar
requested changes
Dec 13, 2018
There was a problem hiding this comment.
@nicolasbrossard Tested it and it works. Just need to change the message to what you proposed when using the -slicepos option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the behaviour of script
get_dicom_info.pl: DICOM files passed as arguments to this script are now reported as not being DICOM only if they don't have header(0020,0032)and-sliceposwas passed on the command line.dcmodify -ecan be useful during testing if one wants to remove header(0020,0032)from an existing DICOM file.This fixes issue #364