[BIDS EEG import bug fix] This fixes a bug happening during the file type determination #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been kindly tested by Iris from the Cuban Brain Mapping project and that resolved the bug she was experiencing so merging it. |
There was a problem hiding this comment.
Looks great to me.
Should tgz and tar.gz or even .zip also be allowed?
And do you want help testing this from others like @nicolasbrossard so you can release this week?
|
@christinerogers actually the regular expression would be able to determine if a file is Hope my explanation makes sense... |
|
perfectly, thanks. i think i'm just forgetting what the BIDS standard includes in the alphabet soup... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug during the file type determination in the python scripts. Instead of looking for the file type string in the whole file path, it now uses a regex to properly match the extension as it should have been done from the beginning...
To test this
Use the code from this branch on the cuban dataset that Iris has.