Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[configuration] New Project can be created without alias although alias is NOT NULL #7948

Closed
ridz1208 opened this issue Jan 11, 2022 · 2 comments · Fixed by #8349
Closed
Assignees
Labels
24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 Category: Bug PR or issue that aims to report or fix a bug State: Discussion required PR or issue that requires the resolution of a discussion with the relevant parties to proceed

Comments

@ridz1208
Copy link
Collaborator

ridz1208 commented Jan 11, 2022

Describe the bug
It is possible to create a new project from the frontend without giving it a valid Alias although the SQL field is set to NOT NULL. It seems like the code stores an empty string in the field to bypass the NOT NULL

Additionally, if the project is then edited to add an alias and saved (saving is successful) and subsequently edited to remove the alias (so go back to empty alias) submitting the form DOES NOT generate any errors, but also DOES NOT clear the alias. A simple reload of the page reveals that the alias is still there...

image

To Reproduce
Steps to reproduce the behaviour (attach screenshots if applicable):

  1. Go to the Configuration module -> Projects
  2. add a new project with no alias (First bug)
  3. add an alias by editing the project
  4. try to remove alias and submit (second bug)

What did you expect to happen?
In both cases an error should be returned forcing the user to enter an alias for the project

@ridz1208 ridz1208 added Category: Bug PR or issue that aims to report or fix a bug 24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 labels Jan 11, 2022
@ridz1208 ridz1208 added the State: Discussion required PR or issue that requires the resolution of a discussion with the relevant parties to proceed label Jan 17, 2023
@ridz1208
Copy link
Collaborator Author

@maltheism while ur at it, make ALIAS required on the front end

@CamilleBeau
Copy link
Contributor

@ridz1208 Did the linked PR solve all of the issues you were having? I can close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 Category: Bug PR or issue that aims to report or fix a bug State: Discussion required PR or issue that requires the resolution of a discussion with the relevant parties to proceed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants