fix generic_includes.php returning error "Undefined variable in /var/www/loris/tools/generic_includes.php on line 28" - 26 branch #9317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmadjar
added
Category: Bug
cmadjar
changed the title
|
These tests seem to all be failing with "./test/dockerized-integration-tests.sh: line 24: docker-compose: command not found" but doesn't look like it's related to the changes in the PR. @kongtiaowang do you have any idea why that would be? @cmadjar how did you test this? I remember there being some interactions with getDatabaseConnection/Database::singleton/NDB_Factory::database() where they had to be called in a certain order to be consistent, but I'm not sure if that's still an issue now that Database::singleton is removed. |
|
@driusan this was tested while upgrading HBCD code to 26. The fix in the PR is resolving the broken generic_includes.php |
…ww/loris/tools/generic_includes.php on line 28
cmadjar
force-pushed
the
fix_generic_includes
branch
from
14216db to
0aac66e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This fixes the script
generic_includes.phpthat calls the $DB variable before it is defined when calling LorisInstance.Without this fix, anything calling
generic_includes.phpwill trigger the following error: