Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix generic_includes.php returning error "Undefined variable in /var/www/loris/tools/generic_includes.php on line 28" - 25 branch #9318

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

cmadjar
Copy link
Collaborator

@cmadjar cmadjar commented Aug 7, 2024

Brief summary of changes

This fixes the script generic_includes.php that calls the $DB variable before it is defined when calling LorisInstance.

Without this fix, anything calling generic_includes.php will trigger the following error:

Undefined variable in /var/www/loris/tools/generic_includes.php on line 28
PHP Fatal error:  Uncaught TypeError: LORIS\\LorisInstance::__construct(): Argument #1 ($db) must be of type Database, null given, called in /var/www/loris/tools/generic_includes.php on line 27

@cmadjar cmadjar added Category: Bug PR or issue that aims to report or fix a bug Critical to release PR or issue is key for the release to which it has been assigned 25.0.0 - Bugs labels Aug 7, 2024
…ww/loris/tools/generic_includes.php on line 28
@cmadjar cmadjar force-pushed the fix_generic_include_v25 branch from 9c17360 to 9b3b110 Compare August 12, 2024 16:52
@driusan driusan merged commit 99018de into aces:25.0-release Oct 1, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
25.0.0 - Bugs Category: Bug PR or issue that aims to report or fix a bug Critical to release PR or issue is key for the release to which it has been assigned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants