FslMelodic has some very inefficient code

[prioux]

Seen in fsl_melodic/portal/portal.rb

It takes minutes to generate a simple list of template files tagged by "template" using this code:

  def get_template_files
    template_files = []
    current_user = User.find(self.user_id)
    user_tags = current_user.available_tags.select {|t| t.name =~ /TEMPLATE/i}
    user_tags.each do |tag|
      user_files ||= Userfile.find_all_accessible_by_user(current_user)
      template_files.concat user_files.select { |u| u.tag_ids.include? tag.id }
    end
    return template_files.map { |f| [f.name,f.id.to_s]}
  end

A user generated over 100,000 DB request because of that.

My solution which is instantaneous:

  def get_template_files
    current_user = User.find(self.user_id)
    tag_ids = current_user.available_tags.where(["name like ?","%template%"]).pluck(:id)
    Userfile.find_all_accessible_by_user(current_user)
    .joins(:tags).where('tags.id' => tag_ids)
    .raw_rows('userfiles.name', 'userfiles.id')
  end

Careful, the IDs returned are no longer strings. Adjust if needed.