Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overlays and points of interests #5

Open
WUOTE opened this issue Mar 23, 2024 · 3 comments
Open

Add overlays and points of interests #5

WUOTE opened this issue Mar 23, 2024 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@WUOTE
Copy link
Contributor

WUOTE commented Mar 23, 2024

We want to provide functionality similar to the old easyzoom maps'.

In order to do that, we need to implement overlays, the easiest way to do this is to partially reuse the easyzoom's overlays by extracting useful info, then readjusting them to the new maps' sizes found in the dzi files for the maps:

"https://regular-hd.acidflow.stream/maps/regular/regular-2024-02-06-78633191.dzi",

{"Image":{"xmlns":"http://schemas.microsoft.com/deepzoom/2008","Format":"webp","Overlap":"2","TileSize":"512","Size":{"Width":"51200","Height":"73728"},"TopLeft":{"X":"-25600","Y":"-31744"}}}

Easyzoom overlays are stored like this.

@WUOTE WUOTE added enhancement New feature or request help wanted Extra attention is needed labels Mar 23, 2024
@SquaredCub
Copy link

I have been looking into this but can't figure out the math to convert easyzoom's data to your map's coordinates.
Do you have any pointers to help me figure this out ? Figuring out new coordinates seems dreadful if it can be avoided for most POI

@WUOTE
Copy link
Contributor Author

WUOTE commented Jun 8, 2024

I have been looking into this but can't figure out the math to convert easyzoom's data to your map's coordinates. Do you have any pointers to help me figure this out ? Figuring out new coordinates seems dreadful if it can be avoided for most POI

Thank you for looking at this issue.
@Dadido3 had a similar idea, and we can try converting coords, but it seems that we would be better off recreating new overlays from scratch:

  1. No spam / bot messages compared to the old easyzoom map Letaali made.
  2. Ability to separate POIs to different layers (similar to how I started with the Bosses overlay).
  3. The old map and the new map's dimentions might not be the same since Letaali used to capture the "skinnier" version.

I haven't found a better overlay mechanism than the one currently being used, what can be done is shown on D3's implementation of the map.

If you choose to test coords conversion first, this helper plugin should help:

  1. Demo
  2. Repo

@SquaredCub
Copy link

SquaredCub commented Jun 8, 2024

Hey cheers for the quick reply. It seems I misunderstood the scope of this issue.
I thought you just wanted to add more data to the current overlayText variable and figured it was something easy enough I could contribute to.

I have created a pull request having my idea in mind but feel free to discard it if you want as I clearly misread your intentions.

I might look into what you actually wanted but I am afraid it looks slightly out of my knowledge.

UPDATE :
I updated the PR to reflect more what I think you were hoping for.
Thanks for your time !

Here's a sneak peak :
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: In Progress
Development

No branches or pull requests

2 participants