Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Chandra.Time with cxotime #18

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Replace Chandra.Time with cxotime #18

merged 1 commit into from
Jan 5, 2021

Conversation

jzuhone
Copy link
Member

@jzuhone jzuhone commented Jan 4, 2021 •
edited
Loading

Description

This PR replaces DateTime from Chandra.Time with CxoTime from cxotime.

Testing

  • Passes unit tests on MacOS, linux, Windows (at least one required)
  • Functional testing

@Gregg140
Copy link
Contributor

Gregg140 commented Jan 4, 2021

Looks good

Gregg140
Gregg140 approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@Gregg140 Gregg140 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jzuhone jzuhone requested a review from jeanconn January 4, 2021 19:33
@jzuhone jzuhone merged commit 9c321b6 into acisops:master Jan 5, 2021
This was referenced Jan 5, 2021
Closed
Merged
@javierggt javierggt mentioned this pull request Mar 2, 2021
Merged
@javierggt javierggt mentioned this pull request Mar 30, 2022
Merged
@javierggt javierggt mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jazan12 jazan12 jazan12 approved these changes

@Gregg140 Gregg140 Gregg140 approved these changes

@taldcroft taldcroft Awaiting requested review from taldcroft

@jeanconn jeanconn Awaiting requested review from jeanconn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jzuhone @Gregg140 @jazan12