Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do I need to vendorize imgui_support.rs? #64

Closed
ctrlcctrlv opened this issue Sep 8, 2020 · 2 comments
Closed

Why do I need to vendorize imgui_support.rs? #64

ctrlcctrlv opened this issue Sep 8, 2020 · 2 comments

Comments

@ctrlcctrlv
Copy link

Why isn't it part of skulpin_plugin_imgui?

@aclysma
Copy link
Owner

aclysma commented Sep 8, 2020

It's a bit too opinionated. It loads specific font files, ranges of characters, and has an unsafe strategy dealing with imgui being "global" that not everyone will agree with.

BTW if you do use it, you may want to remove the gamma correction code. I noticed that it's incorrect for a number of my projects and should simply be removed. (like this: aclysma/imgui-inspect@5598c08)

@aclysma aclysma closed this as completed Sep 8, 2020
@ctrlcctrlv
Copy link
Author

Thanks for the explanation and advice. I am using it yes, see MFEK/glif#3. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants