Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg 7.0 support #142

Open
sebastinas opened this issue Aug 12, 2024 · 2 comments
Open

ffmpeg 7.0 support #142

sebastinas opened this issue Aug 12, 2024 · 2 comments

Comments

@sebastinas
Copy link

sebastinas commented Aug 12, 2024

chromaprint fails its tests with ffmpeg 7.0:

[ RUN      ] FFmpegAudioReaderTest.ReadRaw
./src/audio/ffmpeg_audio_reader_test.cpp:18: Failure
Expected equality of these values:
  2
  reader.GetChannels()
    Which is: 1

[  FAILED  ] FFmpegAudioReaderTest.ReadRaw (7 ms)

See for example https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1072404. Arch and Debian have applied a similar patch to address this issue, but users are experiencing issues. It would be great if ffmpeg 7.0 support could be added.

@calestyo
Copy link

calestyo commented Jan 1, 2025

As I found out after some debugging (with having literally no clue about ffmpeg development ^^), at least the problem I’ve seen and described in the aforementioned is probably already fixed by commit 82781d0.

At least the test seem to run through for me and fpcalc produced some value again.

@calestyo
Copy link

calestyo commented Jan 1, 2025

@lalinsky Could you perhaps release a new version with the few commits since 1.5.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants