Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility of removing pinned activesupport version #198

Open
janost opened this issue Jan 27, 2017 · 2 comments
Open

Possibility of removing pinned activesupport version #198

janost opened this issue Jan 27, 2017 · 2 comments

Comments

@janost
Copy link
Contributor

janost commented Jan 27, 2017

Our project uses activerecord 5 and while upgrading to moonshot 1.1, we discovered that moonshot has pinned activesupport < 5.0.0 to retain compatibility with ruby < 2.2.2.
Since activerecord 5 is depending on activesupport 5 that means our dependencies are colliding.

We'd like to propose to drop the pinned version of activesupport. Users running an older ruby version would still be able to pin activesupport if needed.

@askreet
Copy link
Contributor

askreet commented Jan 27, 2017

Maybe we can implement our own duration to string logic, since that's all we use ruby-duration for, which has the dependency on activesupport.

@janost
Copy link
Contributor Author

janost commented Jan 30, 2017

It seems interactive-logger also depends on ruby-duration, so if we decide to go this way, we'll need to remove it from both projects.

This is no longer blocking our upgrade right now, because we need to stick to activerecord 4 for other reasons, but other users might be affected and we plan to upgrade to activerecord 5 in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants