show_all_events option with the create CLI option is not clear how it works

[jamesiarmes]

Issue by nickveenhof
Thursday Mar 10, 2016 at 18:15 GMT
Originally opened as https://github.com/acquia/cloud-moonshot/issues/121

---

in cli.rb there's the following code:

desc :create, 'Create a new environment.'
    option(
      :parent,
      type: :string,
      aliases: '-p',
      desc: "Parent stack to import parameters from. (Default: #{default_parent_stack || 'None'})")
    option :deploy, default: true, type: :boolean, aliases: '-d',
                    desc: 'Choose if code should be deployed after stack is created'
    option :show_all_events, desc: 'Show all stack events during update. (Default: errors only)'
    def create
      controller.create
      controller.deploy_code if options[:deploy]
    end

While trying to document it wasn't clear that if it is present it would act differently. I suggest it should be a boolean so that it can be turned off as well as can be turned on. By default it's turned off if it is not present as an option. This doesn't seem to be following convention that if I type --show_all_event=false it would stop showing it all and only show errors. Perhaps it should be a log_level setting with the option "all" or "errors" and default to "errors" or so?

[jamesiarmes]

Comment by askreet
Thursday Mar 10, 2016 at 18:27 GMT

---

I think a boolean would be a good improvement. As written it behaves as a boolean, but can't be disabled if it were to default to on.