Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Build Management #83

Open
askreet opened this issue Mar 28, 2016 · 3 comments
Open

Discussion: Build Management #83

askreet opened this issue Mar 28, 2016 · 3 comments
Labels

Comments

@askreet
Copy link
Contributor

askreet commented Mar 28, 2016

@ghaabor introduces a list-builds command in #82, which highlights a very real need for the Moonshot pattern: builds management.

I see 3 basic needs:

  • I need to see what builds I have available for deployment or deletion.
  • I need to delete an old, unused build to save money on S3 fees, etc.
  • I need an automated way to prune "one-and-done" developer builds.

I wonder if we want to use a Thor Subcommand pattern for the CLI interface, like:

bin/environment builds list --filter=release
bin/environment builds prune --filter=dev --days=30
bin/environment builds delete v1.0.7-rc2

I have a couple questions I'd love feedback on:

  • Should we tag the developer one-off builds created by deploy-code in some meaningful way that can be used generically by ArtifactRepositories? If so, should prune only work with those builds as safety mechanism?
  • Should we move this functionality outside Moonshot?

Thoughts?

@janost
Copy link
Contributor

janost commented Mar 29, 2016

@askreet I like your CLI proposal.
As for deleting old builds, I believe prune should only delete the dev builds generated by deploy-code.
This seems to be a very useful feature for most users, implementing it as a core functionality would be great.

@unn
Copy link
Contributor

unn commented Mar 30, 2016

I'm 👍 for supporting this in moonshot.

@ghaabor
Copy link

ghaabor commented Mar 31, 2016

Sorry for the late answer, I'm on vacation this week. I like the idea of extending moonshot with a builds subcommand and I think all three of your CLI proposals are perfectly valid.

For your questions:

  • I think pruning for one-time builds is a great idea bit it should not effect custom-named builds.
  • I agree with @janost, this would be an important part related to core moonshot functionality so I'm on the side of not moving it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants