Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape enum values #16

Closed
acrosman opened this issue May 11, 2021 · 1 comment · Fixed by #21
Closed

Escape enum values #16

acrosman opened this issue May 11, 2021 · 1 comment · Fixed by #21
Labels
bug Something isn't working

Comments

@acrosman
Copy link
Owner

Describe the bug
Picklist values with ' in them cause errors.

To Reproduce

  1. Create a picklist value on a Salesforce object that contains a '
  2. Connect to the org and select the object.
  3. Attempt to generate the database from that object. Error appears in the log that includes:

ER_PARSE_ERROR: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near

Expected behavior
Table to be created successfully.
@acrosman acrosman added the bug Something isn't working label May 11, 2021
@acrosman
Copy link
Owner Author

Looks like this really is a knex bug and have reported it there: knex/knex#4481

But will create a local work around until that is resolved.

@acrosman acrosman mentioned this issue May 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simple ' escape for picklist values. acrosman/Salesforce2Sql
1 participant
@acrosman