From 0c4022f5051fbac1b6433620ad3e8187c44db9f1 Mon Sep 17 00:00:00 2001 From: Paul <108695806+pxrl@users.noreply.github.com> Date: Thu, 19 Sep 2024 00:50:09 +0200 Subject: [PATCH 1/2] fix(validateRootBundle): Bump DATAWORKER_FAST_LOOKBACK_COUNT (#1827) The Dataworker complains that 8 bundles is insufficient to cover the 6 hour fillDeadlineBuffer with a 1 hour challenge window, so bump it to 10. --- src/scripts/validateRootBundle.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/scripts/validateRootBundle.ts b/src/scripts/validateRootBundle.ts index 7de4f866b..b21d3255c 100644 --- a/src/scripts/validateRootBundle.ts +++ b/src/scripts/validateRootBundle.ts @@ -48,7 +48,7 @@ export async function validate(_logger: winston.Logger, baseSigner: Signer): Pro // enough data to limit # of excess historical deposit queries. // - SPOKE_ROOTS_LOOKBACK_COUNT unused in this script so set to something < DATAWORKER_FAST_LOOKBACK_COUNT // to avoid configuration error. - process.env.DATAWORKER_FAST_LOOKBACK_COUNT = "8"; + process.env.DATAWORKER_FAST_LOOKBACK_COUNT = "10"; process.env.SPOKE_ROOTS_LOOKBACK_COUNT = "1"; const { clients, config, dataworker } = await createDataworker(logger, baseSigner); logger[startupLogLevel(config)]({ From 045264498bc2d8286b1d8313da1ea8034028f0cb Mon Sep 17 00:00:00 2001 From: bmzig <57361391+bmzig@users.noreply.github.com> Date: Thu, 19 Sep 2024 07:25:57 -0500 Subject: [PATCH 2/2] fix: do not submit multicall transactions with no calldata (#1828) Signed-off-by: bennett --- src/clients/MultiCallerClient.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/clients/MultiCallerClient.ts b/src/clients/MultiCallerClient.ts index 8769b518b..da4390fa7 100644 --- a/src/clients/MultiCallerClient.ts +++ b/src/clients/MultiCallerClient.ts @@ -633,7 +633,8 @@ export class TryMulticallClient extends MultiCallerClient { mrkdwn: mrkdwn.join(""), }; }; - txnRequestsToSubmit.push(...txnCalldataToRebuild.map(rebuildTryMulticall)); + const tryMulticallTxns = txnCalldataToRebuild.filter((txn) => txn.calldata.length !== 0).map(rebuildTryMulticall); + txnRequestsToSubmit.push(...tryMulticallTxns); } if (simulate) {