Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for open telemetry #1386

Open
kwngo opened this issue Apr 25, 2022 · 5 comments
Open

Adding support for open telemetry #1386

kwngo opened this issue Apr 25, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@kwngo
Copy link

kwngo commented Apr 25, 2022

Is your feature request related to a problem? Please describe.
Often we have trouble distinguishing whether root cause of any issue is something with the controller or our own self-hosted infrastructure. For example I'd like to see how long specific methods in the reconcilation loop are taking to run, to rule out any issues.

Describe the solution you'd like
Similar to open metrics I'm thinking we can add support for open telemetry.

Describe alternatives you've considered
We've enabled the open metrics which has already given us a lot more insight, but I think tracing will take it further.

Additional context

@mumoshu
Copy link
Collaborator

mumoshu commented Apr 26, 2022

@kwngo Hey! This doesn't sound too bad, but I'm unsure it is worth the effort, or how we should prioritize this over other important issues.

What are the exact use-cases you have in mind? Have you ever encountered any performance problems using ARC, caused by GitHub API slowness, K8s slowness, or ARC's logic bug that makes it very slow to respond, etc?
Or is this being suggested only to prepare for such events?

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale label May 27, 2022
@mumoshu mumoshu added this to the v0.26.0 milestone May 30, 2022
@mumoshu mumoshu removed the stale label May 30, 2022
@toast-gear toast-gear added the enhancement New feature or request label Jun 3, 2022
@mumoshu
Copy link
Collaborator

mumoshu commented Jul 16, 2022

Until we have a concrete set of requirements for what we want from tracing, we might better hold on until the tracing framework is finalized and added to controller-runtime, so that we don't repeat the effort.
kubernetes-sigs/controller-runtime#305

@mumoshu mumoshu modified the milestones: v0.26.0, v0.27.0 Jul 16, 2022
@mumoshu
Copy link
Collaborator

mumoshu commented Jul 25, 2022

But adding some trace "logs" to some important code paths of ARC would still make sense, regardless of whether we adopt OpenTelemetry tracing. If anyone has any request to add a specific trace log to certain code path in ARC, please raise a feature request for that with your use-case. Thanks 🙏

@mumoshu mumoshu removed this from the v0.27.0 milestone Jul 25, 2022
@pathcl
Copy link

pathcl commented Dec 13, 2023

any ongoing effort? Im interested in working on it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants