-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple label support for gha-runner-scale-set #2445
Comments
Hello! Thank you for filing an issue. The maintainers will triage your issue shortly. In the meantime, please take a look at the troubleshooting guide for bug reports. If this is a feature request, please review our contribution guidelines. |
Agreed, this is important for our use case. For example, I only have enough Windows test machines to do nightly windows testing. However, during the day, those machines may sit idle and could be repurposed as build machines to improve build job throughput. Ideally, I could label both my windows build runners with both "windows" and "windows-build" labels, and my test runners as "windows" and "windows-test". Then I could just specify |
@Link- Could you please point me where I can find information on why it has been decided not to allow support of labels for runnersets? And is there any chance that it will be added in the future?
|
We also have this use case where we have existing runners labeled From my limited understanding of the code, this seems to be due to the design choice to use k8s labels/annotations on the CRDs as a way to pass the name (label) information to the controller. It seems like it would be possible to extend the |
This is absolutely a regression, not an enhancement request. I last deployed ARC for my entire organization at legacy chart version 0.22.0. My entire organization has been using runner labels in a way that absolutely demands multiple labels. I will not force every developer in my organization to rewrite every workflow in my organization to accommodate this artificial limitation. It's almost as though you don't want me to upgrade from the legacy charts. |
I'm closing this issue as it's a duplicate of this discussion: #2921 (comment) |
I just want to add my opinion that this is a huge 👎🏼. It makes it super painful to switch to the new version of runners. |
What would you like added?
Currently it is possible to set only one label gha-runner-scale-set through
runnerScaleSetName
. It would be nice it there would berunnerSetLabels
which would take in array of labels.Example:
Why is this needed?
In previous versions of ARC it was possible to set multiple labels and self-hosted was sort of default label. Having this feature would enable easier switch from ARC to gha-runner-scale-set because it wouldn't be necessary to modify
runs-on: [...]
in workflows which already have these labels in place.Additional context
It seems to possible to pass in multiple labels for the runnerScaleSet code.
The text was updated successfully, but these errors were encountered: