New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize label ends in hyphen, underbar, and dot #3664

Open

and-es wants to merge 1 commit into actions:master from and-es:sanitize-invalid-label

and-es commented Jul 16, 2024

Fixes #3663

The error occurs because a label must start and end with an alphanumeric character in kubernetes(see: https://github.com/kubernetes/kubernetes/blob/9b7a839bde763575af3406158115b16cff513274/staging/src/k8s.io/apimachinery/pkg/util/validation/validation.go#L166)


          fix trimLabelValue

6791dcf

and-es requested review from mumoshu, toast-gear, rentziass and a team as code owners

July 16, 2024 11:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mumoshu Awaiting requested review from mumoshu mumoshu is a code owner

toast-gear Awaiting requested review from toast-gear toast-gear is a code owner

rentziass Awaiting requested review from rentziass rentziass is a code owner

At least 1 approving review is required to merge this pull request.