-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: explicit fetch-depth:0 to also fetch tags #204
Comments
Also related to #155 - would be good to +1 that PR to help prioritize |
note, |
Overlooked |
Agree. I'm waffling on whether this feature would still even make sense if #155 were implemented. However, I could also see it leading to user confusion. I'll close this for now unless the maintainers consider this separately valuable. |
Why close this?? There needs to be a simple built in way without having to run separate commands to get full history with tags. #217 |
v2 is great! It's much faster and optimized for most "main" scenarios of running tests or builds on the latest commit.
However, on tag events, a very common workflow is to publish the tag as a release somewhere (homebrew, npm, github releases, etc). A major component of most release flows is generating release notes which requires knowledge of prior tags.
Using v2, I expected
fetch-depth:0
to make this possible.Problematic run: https://github.com/nodenv/nodenv/runs/549286319?check_suite_focus=true
Error:
workflow:
My hope is that when fetch-depth:0 is supplied (which implies we want all history) that tags will be fetched as well. I believe this would keep the non-tag "main" scenario fast as desired; while also making the most common tagging scenario more intuitive.
related to #100
The text was updated successfully, but these errors were encountered: