-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark previous PR comment as outdated #628
Comments
@henriquevcosta updating outdated comments should work by default: Note the " Do you know any reproduction steps we could follow to try to reproduce? |
@henriquevcosta - i just fixed this by changing the workflow configuration to always allow comments: - comment-summary-in-pr: on-failure
+ comment-summary-in-pr: always |
@febuiles I'm sorry I've not commented on this for a while, I was away and I still haven't been able to allocate the time to reproduce this. Looking at the comment from blaw2422 and your example PR I'm guessing that the update will not be performed if I have |
@henriquevcosta The comment behavior should be more consistent indeed! There's another open issue now regarding how comments work: #647, will post a link to this issue there! |
I've had some instances in my repos where there was a dependency review comment highlighting a vulnerability but once I fix that issue and my build runs again (now without failing) the old comment is still there and visually polluting the conversation tab of the PR.
Would it be possible for the action to hide its previous comment in the PR, marking it as outdated, so that it's still there but collapsed by default?
The text was updated successfully, but these errors were encountered: