Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deny-licenses mistakenly blocking LGPL-3.0 license #635

Open
logan-porelle opened this issue Dec 6, 2023 · 1 comment
Open

deny-licenses mistakenly blocking LGPL-3.0 license #635

logan-porelle opened this issue Dec 6, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@logan-porelle
Copy link

Summary:

When I list LGPL-2.0,LGPLLR as my deny-license list and have PyGitHub==2.1.1 as a third party in my requirements.txt file then the dependency-review action blocks the pull request as a incompatible issue. The problem is that PyGitHub is a LGPL-3.0, not LGPL-2.0 license.

Replicate:

  1. Have dependency-review-action setup like below:
name: 'Dependency Review'
on: [pull_request]

permissions:
  contents: read
  pull-requests: write

jobs:
  dependency-review:
    runs-on: ubuntu-latest
    steps:
      - name: 'Checkout Repository'
        uses: actions/checkout@v3
      - name: 'Dependency Review'
        uses: actions/dependency-review-action@v3.1.4
        with:
          comment-summary-in-pr: true
          deny-licenses: LGPL-2.0,LGPLLR
  1. Open a pull request with a requirements.txt listing PyGithub==2.1.1
  2. Check PR dependency-review-action failure.

Sample Output:

Image

@jonjanego jonjanego added the bug Something isn't working label Jan 31, 2024
@febuiles febuiles self-assigned this Mar 22, 2024
@juxtin
Copy link
Contributor

juxtin commented Jun 13, 2024

Hi @logan-porelle, I've been trying to reproduce this and I haven't been able to so far. Is it still something that you're running into?

Disregard, I had a syntax error in my config. I can reproduce this now 👍

@juxtin juxtin assigned juxtin and unassigned febuiles Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants