-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocking issues (should block but does not) #714
Comments
Hi @austimkelly, thank you for the feedback! re:
This is by design. I've updated the readme to clarify the behavior. |
@austimkelly looking at your example PR I see |
Hi @febuiles Thanks for checking this out. Here's the PR annotations I'm seeing where the denied packages are reported as warnings: My expectation is that these would have red X next to them an also provide a non-zero return to fail the check. I think I see what I missed now here in the logs: I was looking for an Error in the Denied section in the logs and not the top level which does report an action. A couple of suggestions:
So just a little UX issue, but it does seem to make the check fail. Thanks for taking the time to review my issue. |
@austimkelly Thanks for the clarification. I think your suggestions make sense and would improve Do you mind opening a new issue with the feature request? This helps with our board's automations. |
I've seen issues with license detection and package manager issues but I've not seen these two specifically raised.
allow-licenses
anddeny-licenses
cannot be used together.deny-packages
does not block, only warns. Not sure why I only get warnings on this, but the docs say it will block.Here's a readme and PR showing the issues (there's a couple more I showed in the readme):
The text was updated successfully, but these errors were encountered: