-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v5.0.0-alpha.1 #575
Comments
How about setting |
@kachkaev Thanks for the suggested idea! We will consider adding it to the new major release. |
@MaksimZhukov I've been using the alpha for the past moth in multiple repos and everything works as expected. |
Thank you @lucacome for the feedback, we really appreciate it! |
Hi @MaksimZhukov, I can confirm it fixes the issues with the |
Hello everyone! If you have any questions, ideas or concerns, please share them in this issue. |
There seems to be a different bug with
There needs to be an explicit |
@dfandrich, thank you for reporting this! Could you please create a new issue? |
Thanks for the updates in the new beta version - I was wondering why not use consistent casing for all the config keys names? eg. the new I realise that some of this might be my fault as I added some of those keys 😅 I personally don't have a preference, I just went with kebab-case initially because it was the same as the action config, but if the nested changed file options are how y'all would rather future keys are then might make sense to switch |
@joshdales, this is a great point, thank you. We will switch the nested options to kebab-case |
Have the outputs changed or gone away in the beta? I originally used version 4 of the action and grabbed a snippet that outputs the new-labels and all-labels for the run. When I switched to the beta version, this step no longer outputs any labels even if some were added. This is the step I have in my yaml:
The previous step's id is still labeler. |
Some output like this would be welcome by default to help with debugging. Right
now, the logging of the action is rather…sparse.
|
Is there anyway someone can squeeze #688 in to the v5 release please? We title our PRs with [FEATURE], [BUG], [CHORE], etc. and it would be nice to auto-label based off of that so we can automate our release notes. 🙏 |
@MaksimZhukov May I second that I can't think of any reason someone would want not to match dotfiles on path specs that do match them, it's not as if it's something weird & controversial like an 'implied dot' where '^foobar$' matches both 'foobar' and '.foobar'. It's just a random gotcha. |
Hello everyone! Thank you all for your feedback and patience! We really appreciate this! |
We released the new alpha version of the action. It introduces the following major changes:
sync-labels
input. Now the input value is read correctly.any
selector to match ANY file against ANY glob pattern.For more information, see the release notes.
This is an alpha release and we would like to ask you to try it out and provide us with your feedback. If you have any questions, ideas or concerns, please share them in this issue.
Thank you!
The text was updated successfully, but these errors were encountered: