Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition in dependabot PRs cancels newest jobs in favor of older ones #3377

Open
juanpaucar opened this issue Jul 8, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@juanpaucar
Copy link

juanpaucar commented Jul 8, 2024

Describe the bug
We've noticed that dependabot's PRs often suffer from this issue:

  • The newest enqueued job gets canceled in favor of older ones
    • This doesn't happen in regular PRs from human users
    • This doesn't always happen, it looks more like a race condition thing, thus it's not always reproducible
  • Checks for PR mergeability include a look at the newest run of CI which was previously canceled

To Reproduce
Steps to reproduce the behavior:

Current ci config:

concurrency:
  group: ${{ github.workflow }}-${{ github.ref }}
  cancel-in-progress: true
  1. Dependabot opens a PR
  2. Sometimes it will cancel the newest enqueued CI job instead of canceling the older one in favor of the newest one
  3. This causes CI checks to fail as it looks at the newest run

Expected behavior
New pushes to the dependabot PR should trigger a run that should cancel the previous job so that CI checks accurately read the latest job

Runner Version and Platform

Version of your runner?

OS of the machine running the runner? ubuntu-latest.

What's not working?

Failed enqueued job

Job Log Output

NA

Runner and Worker's Diagnostic Logs

NA

@juanpaucar juanpaucar added the bug Something isn't working label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant